Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
IlyasRidhuan
commented
Aug 22, 2025
IlyasRidhuan
commented
Aug 22, 2025
| // Calldata info from parent context | ||
| uint32_t parent_cd_addr; | ||
| uint32_t parent_cd_size_addr; | ||
| uint32_t parent_cd_size; |
Contributor
Author
There was a problem hiding this comment.
it's not an address any longer, it's loaded into a register
IlyasRidhuan
commented
Aug 22, 2025
| .bytecode_id = parent_context.get_bytecode_manager().try_get_bytecode_id().value_or(FF(0)), | ||
| .is_static = parent_context.get_is_static(), | ||
| .parent_cd_addr = parent_context.get_parent_cd_addr(), | ||
| .parent_cd_size = parent_context.get_parent_cd_size(), |
IlyasRidhuan
force-pushed
the
ir/08-14-fix_avm_data_copy_permutation
branch
2 times, most recently
from
cc1251a to
7b772e2
Compare
IlyasRidhuan
force-pushed
the
ir/08-14-fix_avm_data_copy_permutation
branch
2 times, most recently
from
0d923ca to
d8e3a52
Compare
IlyasRidhuan
commented
Aug 25, 2025
| pol commit parent_calldata_addr; | ||
| pol commit parent_calldata_size; | ||
|
|
||
| pol commit last_child_id; |
Contributor
Author
There was a problem hiding this comment.
Constraints added in later PR
IlyasRidhuan
requested review from
LeilaWang,
Maddiaa0,
fcarreiro and
jeanmon
as code owners
This was referenced Aug 25, 2025
IlyasRidhuan
force-pushed
the
ir/08-14-fix_avm_data_copy_permutation
branch
from
d8e3a52 to
456ebd1
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
IlyasRidhuan
force-pushed
the
ir/08-14-fix_avm_data_copy_permutation
branch
from
456ebd1 to
76b8c1e
Compare
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Aug 28, 2025
Implements the permutations for cd_copy and rd_copy to the execution trace. It needs to be two different permutations (even though they lead to the same gadget) because they operate on different columns of execution (parent vs child). Hence, most instance of `DATACOPY` have been split into `CDCOPY` and `RDCOPY` There was also a range of bug fixes uncovered because of this. 1. Not including the parent calldata size at enqueued call contexts in execution. 2. Not serialized parent calldata information in the when entering a new call Calldata size needs to be properly handled at the tx trace level (in conjunction with calldata hashing). It's not solved here but tracked [here](#14666)
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Aug 29, 2025
Adds the constraints for the `last_child_id` introduced in #16531. It has similar behaviour to other return data information stored in the context
ludamad
pushed a commit
that referenced
this pull request
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the permutations for cd_copy and rd_copy to the execution trace. It needs to be two different permutations (even though they lead to the same gadget) because they operate on different columns of execution (parent vs child). Hence, most instance of
DATACOPYhave been split intoCDCOPYandRDCOPYThere was also a range of bug fixes uncovered because of this.
Calldata size needs to be properly handled at the tx trace level (in conjunction with calldata hashing). It's not solved here but tracked here